-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop relying on .egg-info
directories for kedro micropkg
#2567
Labels
Issue: Feature Request
New feature or improvement to existing feature
Milestone
Comments
astrojuanlu
added
the
Issue: Feature Request
New feature or improvement to existing feature
label
May 8, 2023
5 tasks
merelcht
modified the milestones:
Move to `pyproject.toml` package definition format,
Modernise packaging flows
May 9, 2023
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 29, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 30, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 30, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
May 30, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
Jun 5, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
Jun 5, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
Jun 5, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
Jun 13, 2023
Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
added a commit
that referenced
this issue
Jun 13, 2023
* Make `kedro micropkg package` accept `--verbose` Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Improve error when `micropkg pull` does not find sdist Fix gh-2542. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Stop using pkg_resources Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Do not rely on setup.py to generate sdist See gh-2414. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Stop relying on .egg-info directories Fix gh-2567. Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Note change from pkg_requirements See pypa/packaging#644 (comment) Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Improve code comments Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Fix equality checks of equivalent requirements Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add micropackaging improvements to release notes Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Revert sdist check to make it more testable Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Fix micropkg pull error handling Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add tests for new micropkg pull branches Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Remove untested path of private code Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Fix micropkg tests Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Add more detailed explanation of Requirement custom subclass Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> --------- Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Just in time 👀 https://github.com/pypa/setuptools/blob/49fec9fafb0e23e0dde52d3c4c410d23a2de9b0d/CHANGES.rst?plain=1#L8-L11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
While working on gh-2273, I realized that
kedro micropkg
relies on finding.egg-info
directories to locate packages:kedro/kedro/framework/cli/micropkg.py
Lines 146 to 154 in 6531457
However,
.egg-info
directories are a legacy setuptools artifact and they're in the process of going away, see https://github.com/pypa/setuptools/milestone/3The code was implemented in dbe6d89, which is part of #1263 and was recently touched by #1848. I couldn't find any discussion as to why
dist-info
was dropped in favor ofegg-info
.Possible Implementation
Since
_unpack_sdist
is called right before, IIUC the location of the project metadata file (at the momentsetup.py
, in the futurepyproject.toml
, see gh-2414) should be known. But I am surely missing something here.The text was updated successfully, but these errors were encountered: