Skip to content

Commit

Permalink
Remove setuptools dependency (#3437)
Browse files Browse the repository at this point in the history
---------

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
  • Loading branch information
DimedS authored Dec 21, 2023
1 parent fc9b70b commit fb09b32
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
## Bug fixes and other changes
* Removed example pipeline requirements when examples are not selected in `tools`.
* Allowed modern versions of JupyterLab and Jupyter Notebooks.
* Removed setuptools dependency

## Breaking changes to the API
* Added logging about not using async mode in `SequentiallRunner` and `ParallelRunner`.
Expand Down
9 changes: 5 additions & 4 deletions kedro/framework/cli/micropkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from rope.contrib import generate
from rope.refactor.move import MoveModule
from rope.refactor.rename import Rename
from setuptools.discovery import FlatLayoutPackageFinder

from build.util import project_wheel_metadata
from kedro.framework.cli.pipeline import (
Expand Down Expand Up @@ -227,9 +226,11 @@ def _pull_package( # noqa: PLR0913
# However, the rest of the code expects the non-normalized package name,
# so we have to find it.
packages = [
package
for package in FlatLayoutPackageFinder().find(project_root_dir)
if "." not in package
project_item.name
for project_item in project_root_dir.iterdir()
if project_item.is_dir()
and project_item.name != "tests"
and (project_item / "__init__.py").exists()
]
if len(packages) != 1:
# Should not happen if user is calling `micropkg pull`
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ dependencies = [
"PyYAML>=4.2,<7.0",
"rich>=12.0,<14.0",
"rope>=0.21,<2.0", # subject to LGPLv3 license
"setuptools>=65.5.1",
"toml>=0.10.0",
"toposort>=1.5", # Needs to be at least 1.5 to be able to raise CircularDependencyError
]
Expand Down

0 comments on commit fb09b32

Please sign in to comment.