Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI build failure due to secret scan and missing toposort dependency #1819

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Mar 26, 2024

Description

Development notes

QA notes

  • CircleCI build should pass
  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix Secret Scan CI failure Fix CircleCI build failure due to secret scan and missing toposort dependency Mar 26, 2024
@astrojuanlu
Copy link
Member

I see there's an actual dependency on toposort

from toposort import CircularDependencyError, toposort_flatten

@ravi-kumar-pilla
Copy link
Contributor Author

I see there's an actual dependency on toposort

from toposort import CircularDependencyError, toposort_flatten

yes @astrojuanlu . I think we were using this dependency from Kedro environment. Now that Kedro has dropped it, I added the requirement to our requirements file and will create a ticket to see if we can migrate to graphlib completely. Thanks

@astrojuanlu astrojuanlu removed their request for review March 27, 2024 11:54
@astrojuanlu
Copy link
Member

Don't block this one on my review, I'll be in meetings all day 😅

@ravi-kumar-pilla ravi-kumar-pilla merged commit 4fe056b into main Mar 27, 2024
17 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/secret-scan-ci branch March 27, 2024 14:18
@rashidakanchwala rashidakanchwala mentioned this pull request Apr 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants