Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding toposort as kedro-viz dependency #1849

Closed
1 task
noklam opened this issue Apr 8, 2024 · 1 comment
Closed
1 task

Adding toposort as kedro-viz dependency #1849

noklam opened this issue Apr 8, 2024 · 1 comment

Comments

@noklam
Copy link
Contributor

noklam commented Apr 8, 2024

Description

Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..."
When I install Kedro-viz with latest kedro, I get an immediate error.

[04/08/24 11:31:36] WARNING Failed to load kedro_viz.launchers.cli commands from utils.py:378
EntryPoint(name='kedro-viz',
value='kedro_viz.launchers.cli:viz_cli',
group='kedro.global_commands'). Full exception: No module named
'toposort'

from toposort import CircularDependencyError, toposort_flatten

Context

Why is this change important to you? How would you use it? How can it benefit other users?
This is a bug because the dependency is not mentioned.

Possible Implementation

(Optional) Suggest an idea for implementing the addition or change.
temporary fix: add toposort in kedro viz dependency.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.
Drop dependency completely as kedro-org/kedro#3728 did

Checklist

  • Include labels so that we can categorise your feature request
@rashidakanchwala
Copy link
Contributor

Closing this as toposort has already been added as a viz dependency and there exists a ticket to migrate to graphlib #1820

@rashidakanchwala rashidakanchwala closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants