Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop toposort and migrate to graphlib #1820

Closed
1 task done
ravi-kumar-pilla opened this issue Mar 26, 2024 · 1 comment
Closed
1 task done

Drop toposort and migrate to graphlib #1820

ravi-kumar-pilla opened this issue Mar 26, 2024 · 1 comment
Assignees
Labels
Dependencies Pull requests that update a dependency file Issue: Feature Request Python Pull requests that update Python code

Comments

@ravi-kumar-pilla
Copy link
Contributor

ravi-kumar-pilla commented Mar 26, 2024

Description

This ticket aims at dropping toposort dependency in favor of built-in graphlib if possible. Following how Kedro team did this - kedro-org/kedro#3728

Context

We were depending on Kedro's environment for toposort dependency and since Kedro dropped this dependency, Viz started failing. This also raises an issue of having transitive dependencies. We can improve the code base to remove such transitive dependencies in future - #1821

Possible Implementation

We use from toposort import CircularDependencyError, toposort_flatten in our layers module. We need to find an alternate implementation to toposort_flatten within graphlib to resolve this issue

Possible Alternatives

Checklist

  • Include labels so that we can categorise your feature request
@ravi-kumar-pilla ravi-kumar-pilla added Dependencies Pull requests that update a dependency file Issue: Feature Request Python Pull requests that update Python code labels Mar 26, 2024
@SajidAlamQB
Copy link
Contributor

Completed in: #1942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Issue: Feature Request Python Pull requests that update Python code
Projects
Status: Done
Development

No branches or pull requests

2 participants