Skip to content

Commit

Permalink
Lint fixes related to too-many-positional-arguments
Browse files Browse the repository at this point in the history
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
  • Loading branch information
jitu5 committed Sep 30, 2024
1 parent 193aa59 commit deb95f6
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions package/kedro_viz/data_access/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ def add_node(
self.tags.add_tags(task_node.tags)
return task_node

# pylint: disable=too-many-positional-arguments
def add_node_input(
self,
registered_pipeline_id: str,
Expand Down
1 change: 1 addition & 0 deletions package/kedro_viz/integrations/kedro/data_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ def _load_data_helper(
return catalog, pipelines_dict, session_store, stats_dict


# pylint: disable=too-many-positional-arguments
def load_data(
project_path: Path,
env: Optional[str] = None,
Expand Down
1 change: 1 addition & 0 deletions package/kedro_viz/integrations/kedro/telemetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def get_heap_app_id(project_path: Path) -> Optional[str]:
return None


# pylint: disable=broad-exception-caught
def get_heap_identity() -> Optional[str]: # pragma: no cover
"""Reads a UUID from a configuration file or generates and saves a new one if not present."""
if not _IS_TELEMETRY_INSTALLED:
Expand Down
2 changes: 1 addition & 1 deletion package/kedro_viz/launchers/cli/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
is_flag=True,
help="An experimental flag to open Kedro-Viz without Kedro project dependencies",
)
# pylint: disable=import-outside-toplevel, too-many-locals
# pylint: too-many-positional-arguments, disable=import-outside-toplevel, too-many-locals
def run(
host,
port,
Expand Down
1 change: 1 addition & 0 deletions package/kedro_viz/launchers/cli/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ def display_cli_message(msg, msg_color=None):
)


# pylint: disable=too-many-positional-arguments
def _load_and_deploy_viz(
platform,
is_all_previews_enabled,
Expand Down
2 changes: 2 additions & 0 deletions package/kedro_viz/models/flowchart.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ def create_task_node(
)

@classmethod
# pylint: disable=too-many-positional-arguments
def create_data_node(
cls,
dataset_id: str,
Expand Down Expand Up @@ -216,6 +217,7 @@ def create_data_node(
)

@classmethod
# pylint: disable=too-many-positional-arguments
def create_parameters_node(
cls,
dataset_id: str,
Expand Down
3 changes: 2 additions & 1 deletion package/kedro_viz/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def populate_data(
data_access_manager.add_pipelines(pipelines)


# pylint: disable=too-many-positional-arguments
def load_and_populate_data(
path: Path,
env: Optional[str] = None,
Expand All @@ -70,7 +71,7 @@ def load_and_populate_data(
populate_data(data_access_manager, catalog, pipelines, session_store, stats_dict)


# pylint: disable=too-many-locals
# pylint: disable=too-many-positional-arguments
def run_server(
host: str = DEFAULT_HOST,
port: int = DEFAULT_PORT,
Expand Down

0 comments on commit deb95f6

Please sign in to comment.