Skip to content

Commit

Permalink
Merge branch 'main' into feature/viz_telemetry
Browse files Browse the repository at this point in the history
Signed-off-by: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
  • Loading branch information
jitu5 committed Sep 30, 2024
2 parents 50651b3 + 03d4c9b commit 296a8f8
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ Now you're ready to begin development. Start the development server:
npm start
```

> _*Note*_: If you face any issues running this, we recommend installing Node.js v18:
>
> 1. Delete `package-lock.json` and `node_modules`.
> 2. Run `npm install` to reinstall dependencies.
This will serve the app at [localhost:4141](http://localhost:4141/), and watch files in `/src` for changes. It will also update the `/lib` directory, which contains a Babel-compiled copy of the source. This directory is exported to `npm`, and is used when importing as a React component into another application. It is updated automatically when you save in case you need to test/debug it locally (e.g. with `npm link`). You can also update it manually, by running

```bash
Expand Down
2 changes: 1 addition & 1 deletion package/.pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ confidence=
# --enable=similarities". If you want to run only the classes checker, but have
# no Warning level messages displayed, use"--disable=all --enable=classes
# --disable=W"
disable=ungrouped-imports,attribute-defined-outside-init,too-many-arguments,duplicate-code,fixme,too-many-positional-arguments,too-many-locals
disable=ungrouped-imports,attribute-defined-outside-init,too-many-arguments,duplicate-code,too-many-positional-arguments,fixme

# Enable the message, report, category or checker with the given id(s). You can
# either give multiple identifier separated by comma (,) or put this option
Expand Down
2 changes: 1 addition & 1 deletion package/kedro_viz/data_access/repositories/catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def get_dataset(self, dataset_name: str) -> Optional["AbstractDataset"]:
else: # pragma: no cover
dataset_obj = self._catalog._get_dataset(dataset_name)
except DatasetNotFoundError:
dataset_obj = MemoryDataset() # type: ignore[abstract]
dataset_obj = MemoryDataset() # pylint: disable=abstract-class-instantiated

return dataset_obj

Expand Down

0 comments on commit 296a8f8

Please sign in to comment.