Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __main__.py files in starters after moving find run command to framework #230

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Aug 6, 2024

Motivation and Context

Closes #228

Development notes

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

… framework

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this Aug 6, 2024
@merelcht merelcht enabled auto-merge (squash) August 6, 2024 09:49
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a comment in other PR see if we want to change it in one go since it's a small change.

kedro-org/kedro#4026 (comment)

Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merelcht merelcht disabled auto-merge August 6, 2024 15:45
@merelcht merelcht enabled auto-merge (squash) August 6, 2024 15:45
@merelcht merelcht requested a review from noklam August 7, 2024 12:20
@merelcht merelcht merged commit c6b9e8b into main Aug 7, 2024
23 checks passed
@merelcht merelcht deleted the update-main-find-run-command branch August 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update starters __main__.py with find run logic from framework
3 participants