Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kedro-telemetry dependency #224

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ElenaKhaustova
Copy link
Contributor

Motivation and Context

Partly solves kedro-org/kedro-plugins#726

Removed the kedro-telemetry dependency from all starters as moving to Kedro core dependencies.

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
@ElenaKhaustova ElenaKhaustova marked this pull request as ready for review July 1, 2024 15:22
@astrojuanlu
Copy link
Member

Maybe this should be the last PR to be merged?

Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ElenaKhaustova , I agree with @astrojuanlu , let's merge it last

@ElenaKhaustova ElenaKhaustova enabled auto-merge (squash) August 1, 2024 10:48
@ElenaKhaustova ElenaKhaustova merged commit b9f51d0 into main Aug 1, 2024
23 checks passed
@ElenaKhaustova ElenaKhaustova deleted the feature/remove-kedro-telemetry-dependency branch August 1, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants