Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pipeline tests location for starters #215

Merged
merged 25 commits into from
Apr 15, 2024

Conversation

lrcouto
Copy link
Contributor

@lrcouto lrcouto commented Apr 4, 2024

Motivation and Context

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

lrcouto and others added 7 commits February 28, 2024 10:21
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
lrcouto and others added 12 commits April 11, 2024 02:38
…ro-org/kedro-starters into change-starters-tests-file-structure
…g/kedro-starters into normalize-kedro-datasets-naming
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
@lrcouto lrcouto marked this pull request as ready for review April 15, 2024 14:54
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested updated datasets' names

All tests are passing when pointing test branch: kedro-org/kedro@main...debug/point-to-second-test-starters-branch

Reverted back to point to main branch, so tests failing is expected

@merelcht merelcht merged commit 835c559 into main Apr 15, 2024
10 of 19 checks passed
@merelcht merelcht deleted the change-starters-tests-file-structure branch April 15, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants