Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(datasets): relax bounds for holoviews, scipy #868

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

deepyaman
Copy link
Member

Description

The bounds are overly strict, so much so that they don't reflect what's in the test dependencies.

Development notes

Discovered the problem because I ran into resolution problems while trying to set up a pixi environment.

I also cleaned up some inconsistent trailing commas.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@deepyaman deepyaman enabled auto-merge (squash) October 7, 2024 02:43
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merelcht merelcht requested a review from noklam October 8, 2024 10:31
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman force-pushed the builds/datasets/relax-some-bounds branch from 2d761df to 763351f Compare October 8, 2024 13:58
@deepyaman deepyaman merged commit 3093af4 into main Oct 10, 2024
14 checks passed
@deepyaman deepyaman deleted the builds/datasets/relax-some-bounds branch October 10, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants