Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(telemetry): Let environment variables override consent from .telemetry file #791

Merged
merged 7 commits into from
Aug 1, 2024
Merged

fix(telemetry): Let environment variables override consent from .telemetry file #791

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
693a184
Always set self._consent
lrcouto Jul 30, 2024
fc2f24d
Lint
lrcouto Jul 30, 2024
bb52245
Merge branch 'main' into fix-telemetry-consent-env-var-override
lrcouto Jul 31, 2024
6e96d5e
Fix merge conflict
lrcouto Jul 31, 2024
06f339e
Merge branch 'main' into fix-telemetry-consent-env-var-override
lrcouto Jul 31, 2024
210a2c2
Merge branch 'main' into fix-telemetry-consent-env-var-override
ElenaKhaustova Aug 1, 2024
90e54f0
Merge branch 'main' into fix-telemetry-consent-env-var-override
astrojuanlu Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions kedro-telemetry/kedro_telemetry/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,7 @@ def after_command_run(self):
def after_context_created(self, context):
"""Hook implementation to send project statistics data to Heap"""

if self._consent is None:
self._consent = _check_for_telemetry_consent(context.project_path)
self._consent = _check_for_telemetry_consent(context.project_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm alright with this fix

self._project_path = context.project_path

@hook_impl
Expand Down