Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update deprecated ruff API .pre-commit-config.yaml #745

Merged
merged 2 commits into from
Jul 22, 2024
Merged

chore: Update deprecated ruff API .pre-commit-config.yaml #745

merged 2 commits into from
Jul 22, 2024

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jul 2, 2024 •
edited
Loading

Description

Ruff on kedro_datasets/*.................................................Failed

  • hook id: ruff-kedro-datasets
  • exit code: 1

error: ruff <path> has been removed. Use ruff check <path> instead.

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@noklam
Update deprecated ruff API .pre-commit-config.yaml
bbe227b 
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
@noklam noklam changed the title Update deprecated ruff API .pre-commit-config.yaml chores: Update deprecated ruff API .pre-commit-config.yaml Jul 2, 2024
@noklam noklam changed the title chores: Update deprecated ruff API .pre-commit-config.yaml chore: Update deprecated ruff API .pre-commit-config.yaml Jul 2, 2024
@noklam noklam enabled auto-merge (squash) July 2, 2024 12:35
@noklam
Copy link
Contributor Author

noklam commented Jul 2, 2024

The failing unit test does not relate to the change.

@ankatiyar
Copy link
Contributor

The failing unit test does not relate to the change.

This failure has been happening on and off, usually re-running solves it @noklam

@noklam noklam merged commit 24cd01c into main Jul 22, 2024
52 checks passed
@noklam noklam deleted the noklam/devops branch July 22, 2024 13:34
merelcht pushed a commit to galenseilis/kedro-plugins that referenced this pull request Aug 27, 2024
@noklam @merelcht
chore: Update deprecated ruff API .pre-commit-config.yaml (kedro-org#745
68baf7b 
)

Update deprecated ruff API .pre-commit-config.yaml

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@ankatiyar ankatiyar ankatiyar approved these changes

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noklam @ankatiyar @merelcht