Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add --telemetry flag to to kedro-telemetry CLI masking tests. #637

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: Add --telemetry flag to to kedro-telemetry CLI masking tests. #637

merged 1 commit into from
Apr 8, 2024

Conversation

lrcouto
Copy link
Contributor

@lrcouto lrcouto commented Apr 8, 2024 •
edited
Loading

Description

Adds the --telemetry flag to the test_get_cli_structure_depth on kedro-telemetry, to account for the same changes done on the main Kedro repository.

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@lrcouto
add telemetry flag to kedro new cli structure tests
8d957a6 
Signed-off-by: lrcouto <laurarccouto@gmail.com>
@lrcouto lrcouto changed the title Add --telemetry flag to to kedro-telemetry CLI masking tests. (fix)Add --telemetry flag to to kedro-telemetry CLI masking tests. Apr 8, 2024
@lrcouto lrcouto changed the title (fix)Add --telemetry flag to to kedro-telemetry CLI masking tests. fix: Add --telemetry flag to to kedro-telemetry CLI masking tests. Apr 8, 2024
@lrcouto lrcouto marked this pull request as ready for review April 8, 2024 15:09
@lrcouto lrcouto mentioned this pull request Apr 8, 2024
Closed
ankatiyar
ankatiyar approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was very quick @lrcouto 💯 Thanks! :D

merelcht
merelcht approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DimedS
DimedS approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lrcouto !

@lrcouto lrcouto enabled auto-merge (squash) April 8, 2024 15:47
@lrcouto lrcouto merged commit d5126e5 into main Apr 8, 2024
15 of 17 checks passed
@lrcouto lrcouto deleted the fix-add-telemetry-flag-cli-masking-test branch April 8, 2024 16:19
tgoelles pushed a commit to tgoelles/kedro-plugins that referenced this pull request Jun 6, 2024
@lrcouto @tgoelles
fix: Add --telemetry flag to to kedro-telemetry CLI masking tests. (k…
0edf586 
…edro-org#637)

add telemetry flag to kedro new cli structure tests

Signed-off-by: lrcouto <laurarccouto@gmail.com>
Signed-off-by: tgoelles <thomas.goelles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noklam noklam noklam approved these changes

@DimedS DimedS DimedS approved these changes

@merelcht merelcht merelcht approved these changes

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu

@ankatiyar ankatiyar Awaiting requested review from ankatiyar

@AhdraMeraliQB AhdraMeraliQB Awaiting requested review from AhdraMeraliQB

@ElenaKhaustova ElenaKhaustova Awaiting requested review from ElenaKhaustova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lrcouto @noklam @DimedS @merelcht @ankatiyar