Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(datasets): don't create connection until need #281

Merged
merged 17 commits into from
Oct 19, 2023
Merged

perf(datasets): don't create connection until need #281

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4129822
perf(datasets): delay `Engine` creation until need
deepyaman Jul 25, 2023
6f7dbe6
chore: don't check coverage in TYPE_CHECKING block
deepyaman Jul 25, 2023
6f162b6
perf(datasets): don't connect in `__init__` method
deepyaman Jul 25, 2023
82d50eb
test(datasets): fix tests to touch `create_engine`
deepyaman Jul 26, 2023
80b6069
perf(datasets): don't connect in `__init__` method
deepyaman Oct 9, 2023
dc80fba
Merge branch 'main' into feat/datasets/delay-connection
deepyaman Oct 9, 2023
d16df18
style(datasets): exec Ruff on sql_dataset.py :dog:
deepyaman Oct 9, 2023
9987951
Undo changes to `engines` values type (for Sphinx)
deepyaman Oct 10, 2023
2be42aa
Patch Sphinx build by removing `Engine` references
deepyaman Oct 10, 2023
54f12b3
perf(datasets): don't connect in `__init__` method
deepyaman Oct 13, 2023
4596898
chore(datasets): don't require coverage for import
deepyaman Oct 13, 2023
134b54d
Merge branch 'main' into feat/datasets/delay-connection
deepyaman Oct 13, 2023
c21c29f
chore(datasets): del unused `TYPE_CHECKING` import
deepyaman Oct 13, 2023
389c642
docs(datasets): document lazy connection in README
deepyaman Oct 13, 2023
356b4dc
Merge branch 'main' into feat/datasets/delay-connection
deepyaman Oct 18, 2023
cb45e17
perf(datasets): remove create in `SQLQueryDataset`
deepyaman Oct 18, 2023
7170589
refactor(datasets): do not return the created conn
deepyaman Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into feat/datasets/delay-connection 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
  • Loading branch information
@deepyaman
deepyaman authored Oct 18, 2023
commit 356b4dcf01b7d719e81d3aa092346d8042f0fd9e
2 changes: 1 addition & 1 deletion kedro-datasets/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ version = {attr = "kedro_datasets.__version__"}
[tool.coverage.report]
fail_under = 100
show_missing = true
omit = ["tests/*", "kedro_datasets/holoviews/*", "kedro_datasets/snowflake/*", "kedro_datasets/tensorflow/*"]
omit = ["tests/*", "kedro_datasets/holoviews/*", "kedro_datasets/snowflake/*", "kedro_datasets/tensorflow/*", "kedro_datasets/__init__.py", "kedro_datasets/databricks/*"]
exclude_lines = ["pragma: no cover", "raise NotImplementedError", "if TYPE_CHECKING:"]

[tool.pytest.ini_options]
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.