Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(datasets): release 1.4.0 #222

Merged
merged 4 commits into from
May 31, 2023
Merged

build(datasets): release 1.4.0 #222

merged 4 commits into from
May 31, 2023

Conversation

noklam
Copy link
Contributor

@noklam noklam commented May 30, 2023 •
edited
Loading

Description

doc fix release together with kedro 0.18.9 kedro-org/kedro#2619

  • Added SparkStreamingDataSet

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@noklam noklam requested a review from astrojuanlu May 30, 2023 15:51
@noklam noklam mentioned this pull request May 30, 2023
Merged
10 tasks
@noklam noklam enabled auto-merge (squash) May 30, 2023 16:03
@noklam
Fix RELEASE.md
57a9841 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@astrojuanlu
Copy link
Member

Approving if kedro-org/kedro#2485 RTD build passes 😄 pointed it to this branch.

@noklam noklam requested a review from merelcht May 30, 2023 16:17
@noklam
Copy link
Contributor Author

noklam commented May 30, 2023

I am adding the streaming dataset to the release if nothing fails. That's huge 🔥

@astrojuanlu
Copy link
Member

I am adding the streaming dataset to the release if nothing fails. That's huge 🔥

Worth bumping to 1.4.0 then?

@noklam
Copy link
Contributor Author

noklam commented May 30, 2023

@astrojuanlu I think we only update when it's breaking? But I see your point bumping the version to signal the newly added features. I'll check again during stand-up tomorrow.

astrojuanlu
astrojuanlu approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked https://kedro--2485.org.readthedocs.build/en/2485/kedro_datasets.html ⭐

@merelcht
Copy link
Member

@astrojuanlu I think we only update when it's breaking? But I see your point bumping the version to signal the newly added features. I'll check again during stand-up tomorrow.

That's true for the core Kedro framework repo, but for the plugins we bump the second number for any new features and the first would be for breaking changes. So it's more like regular semver.

@noklam noklam changed the title build(datasets): release 1.3.1 build(datasets): release 1.4.0 May 31, 2023
merelcht
merelcht approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@noklam noklam merged commit 0c0503c into main May 31, 2023
@noklam noklam deleted the kedro-datasets-1.3.1 branch May 31, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@merelcht merelcht merelcht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noklam @astrojuanlu @merelcht