Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Application Registration to AzureAD for RabbitMQ testing purpose #114

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

kratkyzobak
Copy link
Contributor

Added AzureAD Application Registration to enable test of Azure Workload Identity auth against RabbitMQ as proposed in kedacore/keda#4657

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related to kedacore/keda#4657

@kratkyzobak kratkyzobak requested a review from a team as a code owner June 15, 2023 14:59
@kratkyzobak kratkyzobak force-pushed the azure-ad-rabbitmq-oauth branch 2 times, most recently from 067340b to 6ea475a Compare June 15, 2023 15:10
Signed-off-by: Jakub Adamus <jakub.adamus@vivantis.cz>
@JorTurFer
Copy link
Member

I guess that we will need to add more applications in the future. Could you create the module more abstract in order to reuse it?
I think that we can achieve it just moving this code to outside the module and passing it as variable:

application_name             = "${var.unique_project_name}-rabbitmq-app"
rabbitmq_roles = {
  management = "tag:management"
  administrator = "tag:administrator"
  read_all = "read:*/*/*"
  write_all = "write:*/*/*"
  configure_all = "configure:*/*/*"
}

(and renaming the resources, ofc)

@kratkyzobak kratkyzobak force-pushed the azure-ad-rabbitmq-oauth branch 2 times, most recently from 24b58d8 to 4fee06d Compare June 15, 2023 16:14
…raion)

Signed-off-by: Jakub Adamus <jakub.adamus@vivantis.cz>
@kratkyzobak
Copy link
Contributor Author

@JorTurFer refactored to make it more generic module for app registraion.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JorTurFer JorTurFer merged commit 0af0c1f into kedacore:main Jun 15, 2023
@JorTurFer
Copy link
Member

There is an issue with the SP permission in our side, I'll update the issue once it's solved

@JorTurFer
Copy link
Member

Done, the app has been created! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants