Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add error checking for sqs metrics #6235

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add error checking for sqs metrics #6235

wants to merge 5 commits into from

Conversation

robpickerill
Copy link
Contributor

Add error checking for SQS metrics

Checklist

Fixes #6178

@robpickerill robpickerill requested a review from a team as a code owner October 13, 2024 18:14
@robpickerill
add error checking for sqs metrics to avoid runtime panics
769e4d4 
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
@SpiritZhou
Copy link
Contributor

SpiritZhou commented Oct 16, 2024 •
edited by github-actions bot
Loading

/run-e2e aws_sqs_queue
Update: You can check the progress here

JorTurFer
JorTurFer reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you update the changelog as well?

@robpickerill
update changelog
a8bc0c2 
Signed-off-by: Rob Pickerill <r.pickerill@gmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Oct 21, 2024 •
edited by github-actions bot
Loading

/run-e2e aws_sqs_queue
Update: You can check the progress here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bad queue length strconv.ParseInt call
3 participants
@robpickerill @SpiritZhou @JorTurFer