-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add activation feature for CPU/Memory scaler #6231
Open
kunwooy
wants to merge
2
commits into
kedacore:main
Choose a base branch
from
kunwooy:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JorTurFer You suggested that I query the metrics server directly instead of querying HPA. I have modified the code (#6174 (comment)). If approved, modification to the helm chart is needed since the operator's service account needs permission on pods.metrics.k8s.io APIs |
kunwooy
force-pushed
the
main
branch
3 times, most recently
from
October 11, 2024 08:18
c8f6e16
to
0e3f923
Compare
kunwooy
force-pushed
the
main
branch
9 times, most recently
from
October 14, 2024 03:56
18293de
to
943fce1
Compare
Do you mind updating the CHANGELOG.md as well? |
@SpiritZhou I updated the CHANGELOG.md too. |
kunwooy
force-pushed
the
main
branch
2 times, most recently
from
October 22, 2024 04:09
ae428b8
to
2fb091a
Compare
Signed-off-by: kunwooy <vbtkdpf148@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the cpu & memory scaler lacks the activation feature because it delegates the scaling responsibilities to the built-in Kubernetes HPA controller. As a result, even if the scale target is currently scaled-out by the cpu/memory metric being above the threshold value, if some other Keda scalers which use External Metrics are used in conjunction with the cpu/memory scaler, it will be deactivated (and thus scaled to zero) when all other scalers using External Metrics are deactivated.
Hence, my proposal is to introduce a way to check the activation of the cpu/memory scaler. Since the scaling behavior will be handled by the HPA controller, cpu/memory scaler only needs to feed in the activation value to the scaled object controller in its
GetMetricsAndActivity()
method. Moreover to enable such feature, I introduceactivationValue
field in cpu/memory trigger's metadata.(I have accidentally closed the last pull request: #6174)
Checklist
Fixes #6057
Relates to #