scaler typed config: simplify missing parameter error #6194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
|
I used to think that using brackets was a way to indicate that it can support multiple names. But now it seems that omitting the brackets can make the text more readable. :) |
SpiritZhou
approved these changes
Sep 29, 2024
JorTurFer
approved these changes
Sep 29, 2024
zroubalik
approved these changes
Sep 29, 2024
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rickbrouwer noticed that #5997 introduced a small side effect with how
TypedConfigreturns errors for missing trigger metadata parameter names.This PR improves the readability of the error by going back to
and alternatively listing multiple parameter names as just comma-separated
Checklist