RabbitMQ: provide separate paremeters for user and password #6180
+621
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovics
changed the title
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
tests/scalers/rabbitmq/rabbitmq_queue_http_auth/rabbitmq_queue_http_auth_test.go
Show resolved
Hide resolved
tests/scalers/rabbitmq/rabbitmq_queue_amqp_auth/rabbitmq_queue_amqp_auth_test.go
Show resolved
Hide resolved
dovics
force-pushed
the
feat-rabbitmq-auth
branch
from
f6753dc
to
3d8924f
Compare
1 task
JorTurFer
approved these changes
Oct 2, 2024
|
@kedacore/keda-core-contributors PTAL |
|
/run-e2e rabbit |
Signed-off-by: wangrushen <wrs369@88.com>
Signed-off-by: wangrushen <wrs369@88.com>
wozniakjan
force-pushed
the
feat-rabbitmq-auth
branch
from
a3585f9
to
cc6bfd5
Compare
|
/run-e2e rabbit |
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 21, 2024
…#6180) Signed-off-by: wangrushen <wrs369@88.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
rabbitmq using separate username and password, supports obtaining from environment variables or obtaining from TriggerAuthentication, and remains compatible with previous usage.
Checklist
Fixes #2513
Relates to kedacore/keda-docs#1472