Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Solace scaler config #5856

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Refactor Solace scaler config #5856

merged 5 commits into from
Jun 5, 2024

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Jun 4, 2024 •
edited by zroubalik
Loading

Refactor Solace scaler config

Checklist

Relates to # #5797

@SpiritZhou
Update
74f8769 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 4, 2024 •
edited by github-actions bot
Loading

/run-e2e solace
Update: You can check the progress here

@SpiritZhou
Update
50a304f 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 4, 2024 •
edited by github-actions bot
Loading

/run-e2e solace
Update: You can check the progress here

@SpiritZhou
Fix
e188832 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 4, 2024 •
edited by github-actions bot
Loading

/run-e2e solace
Update: You can check the progress here

@SpiritZhou
Update
bc85f2b 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou marked this pull request as ready for review June 5, 2024 07:08
@SpiritZhou SpiritZhou requested a review from a team as a code owner June 5, 2024 07:08
@SpiritZhou
Copy link
Contributor Author

SpiritZhou commented Jun 5, 2024 •
edited by github-actions bot
Loading

/run-e2e solace
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great work!

@zroubalik zroubalik merged commit fd4fcc3 into kedacore:main Jun 5, 2024
20 checks passed
rxg8255 pushed a commit to rxg8255/keda that referenced this pull request Jun 24, 2024
@SpiritZhou
Refactor Solace scaler config (kedacore#5856)
2833b32 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
uucloud pushed a commit to uucloud/keda that referenced this pull request Jul 11, 2024
@SpiritZhou @uucloud
Refactor Solace scaler config (kedacore#5856)
a5cfad6 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: uucloud <uucloud@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiritZhou @zroubalik @wozniakjan