chore: minor refactor to reduce copy/paste code in ScaledObject webhook #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zroubalik
reviewed
Jan 18, 2024
wozniakjan
force-pushed
the
issue5397/small_refactor_for_so_webhook
branch
from
004f5d7
to
1d6172a
Compare
closes: kedacore#5397 Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
wozniakjan
force-pushed
the
issue5397/small_refactor_for_so_webhook
branch
from
1d6172a
to
4f8797c
Compare
JorTurFer
approved these changes
Jan 21, 2024
|
/run-e2e internal |
|
/run-e2e internal |
|
/run-e2e internal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all in the title :)
intending to merge after 2.13.0 release so keeping as draft for now
Checklist
Fixes #5397