Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ScaledObject): Check default limits from LimitRange for ScaledObject validations #5377

Commits on Jan 16, 2024

  1. fix(ScaledObject): Check Default Limits from LimitRange for ScaledObj…

    …ect Validations
    
    KEDA admission webhook rejects ScaledObject requests with CPU or memory
    triggers when the resource limits (CPU/memory based on triggers) are
    not set in the pod spec. This is expected behavior.
    
    But if default limits are set in the LimitRange object in the same
    namespace, the admission webhook should allow the ScaledObject request,
    which currently doesn’t.
    
    This change will check if there is a LimitRange with default limits
    (CPU/memory based on triggers) in the namespace that ScaledObject is
    in, and allows the request to proceed.
    
    Also, added RBAC permissions for list & watch LimitRange.
    
    Updated Change Log.
    
    Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
    Bhargav-InfraCloud committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    edecc39 View commit details
    Browse the repository at this point in the history