Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump deps and pin k8s.io to 0.28.5 #5346

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

zroubalik
Copy link
Member

Checklist

@zroubalik zroubalik requested a review from a team as a code owner January 3, 2024 15:56
Copy link

github-actions bot commented Jan 3, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@zroubalik
Copy link
Member Author

zroubalik commented Jan 3, 2024

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik mentioned this pull request Jan 3, 2024
25 tasks
@JorTurFer
Copy link
Member

FOSSA issue:
image

@zroubalik
Copy link
Member Author

zroubalik commented Jan 3, 2024

FOSSA issue: image

This transitive dependency is a dual licensed library. Licensed under BSD a GPLv2 licenses. If we assume that we are gonna use the BSD (which is a permissive open source license), then I think that we are good with ignoring this warning and proceed. But I am not a licensing expert nor lawyer :)

Thoughts? @kedacore/keda-maintainers @joelsmith

Our dependency: https://github.com/DataDog/datadog-api-client-go
The transitive dependency causing problems: https://github.com/DataDog/zstd

@JorTurFer
Copy link
Member

FOSSA issue: image

This transitive dependency is a dual licensed library. Licensed under BSD a GPLv2 licenses. If we assume that we are gonna use the BSD (which is a permissive open source license), then I think that we are good with ignoring this warning and proceed. But I am not a licensing expert nor lawyer :)

Thoughts? @kedacore/keda-maintainers @joelsmith

Our dependency: DataDog/datadog-api-client-go The transitive dependency causing problems: DataDog/zstd

yes, you're right! I've updated FOSSA adding an exception for this

@JorTurFer
Copy link
Member

but static checks and e2e tests are failing too

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik
Copy link
Member Author

zroubalik commented Jan 3, 2024

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik merged commit eec9b26 into kedacore:main Jan 3, 2024
19 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants