Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't validate workload with only resource limits set #4803

Merged
merged 7 commits into from
Jan 3, 2024
Merged

fix: don't validate workload with only resource limits set #4803

merged 7 commits into from
Jan 3, 2024

Commits on Dec 21, 2023

  1. fix: don't validate workload with only resource limits set 

    Signed-off-by: Claudio Netto <nettinhorama@gmail.com>
    @nettoclaudio
    nettoclaudio committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    bf214d8 View commit details
    Browse the repository at this point in the history

  2. docs: add resolved issue in changelog 

    Signed-off-by: Claudio Netto <nettinhorama@gmail.com>
    @nettoclaudio
    nettoclaudio committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    11a7abf View commit details
    Browse the repository at this point in the history

  3. fix: preventing possible panic due to nil pointer dereferencing 

    Signed-off-by: Claudio Netto <nettinhorama@gmail.com>
    @nettoclaudio
    nettoclaudio committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4a43163 View commit details
    Browse the repository at this point in the history

  4. test: set CPU/memory scaler specs properly 

    Signed-off-by: Claudio Netto <nettinhorama@gmail.com>
    @nettoclaudio
    nettoclaudio committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    13226a6 View commit details
    Browse the repository at this point in the history

  5. refactor: moving the check of resource validation to helper function 

    Signed-off-by: Claudio Netto <nettinhorama@gmail.com>
    @nettoclaudio
    nettoclaudio committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    1c655d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. test: +e2e to cover that webhook dont validate workload with only lim… 

    …its set

Signed-off-by: Claudio Netto <nettinhorama@gmail.com>
    @nettoclaudio
    nettoclaudio committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    465aebb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into skip-validation-of-workloads-with-only-limit… 

    …s-set
    @nettoclaudio
    nettoclaudio authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    aa43c08 View commit details
    Browse the repository at this point in the history