-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka Scaler: add back strings.TrimSpace()
function for saslAuthType
#4693
Kafka Scaler: add back strings.TrimSpace()
function for saslAuthType
#4693
Conversation
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
Could you update the changelog as well?
@JorTurFer Thanks for the quick review ! Should I put the changelog under the |
I think that under |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
/run-e2e kafka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the fix 🙇
Hi team,
This PR aims to fix #4689. Not sure it could be backported to 2.10. Please advise me on this matter. 🙏
Checklist