Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Scaler: add back strings.TrimSpace() function for saslAuthType #4693

Conversation

dttung2905
Copy link
Contributor

@dttung2905 dttung2905 commented Jun 16, 2023

Hi team,
This PR aims to fix #4689. Not sure it could be backported to 2.10. Please advise me on this matter. 🙏

Checklist

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 requested a review from a team as a code owner June 16, 2023 07:59
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!
Could you update the changelog as well?

@dttung2905
Copy link
Contributor Author

@JorTurFer Thanks for the quick review ! Should I put the changelog under the unreleased or can we backport to 2.10.1 as some users have reported this issue 🤔 ?

@JorTurFer
Copy link
Member

@JorTurFer Thanks for the quick review ! Should I put the changelog under the unreleased or can we backport to 2.10.1 as some users have reported this issue 🤔 ?

I think that under Unreleased -> Fixes is the best place.
Don't worry about v2.10.1, if we backport the fix, we will reorganize during the release process, but I don't think that we will do it because v2.11 will be released next week

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@JorTurFer
Copy link
Member

JorTurFer commented Jun 16, 2023

/run-e2e kafka
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the fix 🙇

@JorTurFer JorTurFer merged commit bce3375 into kedacore:main Jun 16, 2023
@dttung2905 dttung2905 deleted the fix-kafka-scaler-sasl-trigger-authentication-with-extra-char branch June 16, 2023 15:13
pragmaticivan added a commit to pragmaticivan/keda that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka scaler with SASL plaintext auth mode fails with "error parsing kafka metadata: err SASL mode plaintext"
2 participants