New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prometheus_metrics_test.go #4437

Merged

JorTurFer merged 6 commits into kedacore:main from Parthiba-Hazra:test-prometheus

Apr 25, 2023

Contributor

Parthiba-Hazra commented Apr 5, 2023 •

edited by JorTurFer

Loading

write test cases for Prometheus Metrics e2e tests, covered this metrics

keda_scaler_errors
keda_scaler_error_totals
keda_scaled_object_errors
test cases check that Prometheus metrics are correctly incremented in case of an error in a scaler/scaledobject, etc.

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4127

Relates to #4127


          Update prometheus_metrics_test.go

3540bdf

Signed-off-by: Parthiba hazra <parthibahazra@gmail.com>

Parthiba-Hazra requested a review from a team as a code owner

April 5, 2023 16:59

Contributor Author

Parthiba-Hazra commented Apr 5, 2023

Hey @JorTurFer , sorry for the trouble.
I recreate the PR with new branch, thank you.

Parthiba-Hazra mentioned this pull request

Create e2e tests for Prometheus metrics #4416

Closed

4 tasks

Member

JorTurFer commented Apr 5, 2023 •

edited by github-actions bot

Loading

/run-e2e prometheus
Update: You can check the progress here


          Merge branch 'kedacore:main' into test-prometheus

ebda240

Member

zroubalik commented Apr 6, 2023 •

edited by github-actions bot

Loading

/run-e2e prometheus
Update: You can check the progress here

Contributor Author

Parthiba-Hazra commented Apr 6, 2023 •

edited

Loading

Hey, I'm seeing that testScalerErrors function failing.
I tried running the tests many times in my local minikube cluster, it passed each time.
any suggestion?

Member

JorTurFer commented Apr 10, 2023 •

edited by github-actions bot

Loading

/run-e2e prometheus
Update: You can check the progress here

JorTurFer reviewed

View reviewed changes

tests/sequential/prometheus_metrics/prometheus_metrics_test.go Outdated Show resolved Hide resolved

tests/sequential/prometheus_metrics/prometheus_metrics_test.go Outdated Show resolved Hide resolved

tests/sequential/prometheus_metrics/prometheus_metrics_test.go Outdated Show resolved Hide resolved

tests/sequential/prometheus_metrics/prometheus_metrics_test.go Outdated Show resolved Hide resolved

Parthiba-Hazra added 2 commits

April 14, 2023 22:48


          Merge branch 'main' into test-prometheus

d1ac303


          Update prometheus_metrics_test.go

9bc66d9

Signed-off-by: Parthiba hazra <parthibahazra@gmail.com>

Parthiba-Hazra requested a review from JorTurFer

April 20, 2023 15:56

Member

JorTurFer commented Apr 24, 2023 •

edited by github-actions bot

Loading

/run-e2e prometheus
Update: You can check the progress here

JorTurFer approved these changes

View reviewed changes

Member

JorTurFer left a comment

LGTM!
Could you add a record in the changelog linking the issue? The other section looks as the correct place for it

Parthiba-Hazra added 2 commits

April 25, 2023 12:48


          Update CHANGELOG.md

40f40d5

Signed-off-by: Parthiba hazra <parthibahazra@gmail.com>


          Merge branch 'main' into test-prometheus

0a4411e

Member

JorTurFer commented Apr 25, 2023 •

edited by github-actions bot

Loading

/run-e2e prometheus
Update: You can check the progress here

JorTurFer approved these changes

View reviewed changes

JorTurFer enabled auto-merge (squash)

April 25, 2023 08:14

Contributor Author

Parthiba-Hazra commented Apr 25, 2023

Hey @JorTurFer should I mark as checked the all checklists in pr description?

Member

JorTurFer commented Apr 25, 2023

Hey @JorTurFer should I mark as checked the all checklists in pr description?

I have marked them 😄

JorTurFer merged commit 517ca0d into kedacore:main

Member

JorTurFer commented Apr 25, 2023

@Parthiba-Hazra , after the merge, the test is failing in the integration cluster, could you take a look? 🙏
https://github.com/kedacore/keda/actions/runs/4795974230/jobs/8533699499#step:6:38507

JorTurFer reviewed

View reviewed changes

tests/sequential/prometheus_metrics/prometheus_metrics_test.go

Comment on lines +365 to +366

		time.Sleep(2 * time.Second)

Member

JorTurFer Apr 25, 2023

Maybe we need to increase this time to ensure that the metric is exposed

Contributor Author

Parthiba-Hazra Apr 26, 2023

Should I increase it from 2 to 4?

Member

JorTurFer Apr 26, 2023

Or even bigger xD, we need to ensure that the test sin't flaky. I mean, in this case, waiting 2,4,10 seconds doesn't change the test because it's checking > 0, never mind if 1 or 100. If you think that 10 is safer, go with 10 :)

Contributor Author

Parthiba-Hazra Apr 26, 2023

Actually its confusing, cause in my local cluster it's worked well. At least it should pass after 4 seconds, I will change it to 4.

Contributor Author

Parthiba-Hazra Apr 26, 2023

Should I create a new PR on this?

Member

JorTurFer Apr 26, 2023

Yes, please 🙏

Parthiba-Hazra mentioned this pull request

Increase sleeping time in testScalerErrors (prometheus_metrics_test.go) #4481

Merged

4 tasks

JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request


          Update prometheus_metrics_test.go (kedacore#4437)

b011d0c

geoffrey1330 pushed a commit to geoffrey1330/keda that referenced this pull request


          Update prometheus_metrics_test.go (kedacore#4437)

ea94c82

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet