fix(aws-cloudwatch): Not require uneeded fields #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
/run-e2e aws* |
1 task
|
@JorTurFer what about Changelog? |
Does it make sense? If you think so, I can open an issue and add it. I didn't do it because I think that in this case is a minor fix |
I think that it should be added there. |
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
zroubalik
reviewed
Mar 8, 2023
|
/run-e2e aws* |
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
tomkerkhove
reviewed
Mar 8, 2023
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
xoanmm
pushed a commit
to xoanmm/keda
that referenced
this pull request
Mar 22, 2023
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use
expressionin cloudwatch scalers, metricName and namespace aren't needed but even though it, they were required. This PR removes this requirementChecklist
Fixes #4334