Cassandra_scaler improvement #4079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ithesadson <thesadson@gmail.com>
zroubalik
reviewed
Jan 13, 2023
There was a problem hiding this comment.
I am afraid this is breaking change, because the docs mentions that the port could be specified both ways https://keda.sh/docs/2.9/scalers/cassandra/
Shouldn't we instead try to fix the problematic part and keep the possibility to specify port in both places?
@JorTurFer @tomkerkhove wdyt?
Also could you please open an issue for this and link here. Then add a changelog entry (as was mentioned in the PR template that you have removed)
Thanks!
|
I think we should avoid breaking changes |
|
Issue link: #4110 @zroubalik |
|
@ithesadson please don't break the behaviour and keep the original one. Just fix the problem please. |
1 task
1 task
|
closing in favor of #4162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ithesadson thesadson@gmail.com
Current Code: Port information can be assigned in 2 different ways.
a- in clusterIPAddress
b- in port
Change: Removed assignment of port information in clusterIPAddress. Port information can only be entered in the port.
Why is this change necessary?
In case clusterIPAddress contains port information, in previous version of the code there was an unnecessary and incorrect check in clusterIPAddress, it is better to simplify it and only ask to be entered in port variable.
If the clusterIPAddress contains port information, checking if the port information is entered in the clusterIPAddress will cause some errors.
Error example in current code: User enters the following values.
clusterIPAddress: "https://cassandra.test"
port: "9042"
->Expected clusterIPAddress : https://cassandra.test:9042
The actual clusterIPAddress: https://cassandra.test
CheckList