-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scaler): Adds ArangoDB Scaler #4028
Conversation
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job!
some inline comments but it looks good in general ❤️
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
/run-e2e arango* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this awesome job! 🙇
* chore(scaler): add arangodb scaler Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * updated helm install command Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * adds helper function to wait for all pods in the namespace to be running Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * fixes username as base64 input Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * fix helper for deleting arango deployment Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * updates changelog Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * updates changelog Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * resolves ci checks and comments Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * adds function comment Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * removes unnecessary leading newline Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * adds feature for executing any query that returns a float value Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> * resolves pr comments Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io> Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Provide a description of what has been changed
Checklist
Fixes #4000
Relates to kedacore/keda-docs#1018