Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scaler): Adds ArangoDB Scaler #4028

Merged
merged 14 commits into from
Dec 24, 2022
Merged

Conversation

neelanjan00
Copy link
Contributor

@neelanjan00 neelanjan00 commented Dec 19, 2022

Provide a description of what has been changed

  • Adds ArangoDB scaler
  • Adds ArangoDB scaler unit tests
  • Adds ArangoDB scaler E2E tests

Checklist

Fixes #4000

Relates to kedacore/keda-docs#1018

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@neelanjan00 neelanjan00 requested a review from a team as a code owner December 19, 2022 19:28
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!
some inline comments but it looks good in general ❤️

pkg/scalers/arangodb_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/arangodb_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/arangodb_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/arangodb_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/arangodb_scaler.go Outdated Show resolved Hide resolved
tests/scalers/arangodb/arangodb_test.go Outdated Show resolved Hide resolved
tests/scalers/arangodb/arangodb_test.go Outdated Show resolved Hide resolved
tests/scalers/arangodb/helper.go Outdated Show resolved Hide resolved
tests/scalers/arangodb/helper.go Outdated Show resolved Hide resolved
tests/scalers/arangodb/helper.go Outdated Show resolved Hide resolved
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@semgrep-app
Copy link

semgrep-app bot commented Dec 23, 2022

Semgrep found 16 wrong-wrapped-error findings:

Semgrep found a possible error wrong wrapped.

Created by wrong-wrapped-error.

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@JorTurFer
Copy link
Member

JorTurFer commented Dec 23, 2022

/run-e2e arango*
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this awesome job! 🙇

@JorTurFer JorTurFer merged commit 71850e5 into kedacore:main Dec 24, 2022
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Jan 9, 2023
* chore(scaler): add arangodb scaler

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* updated helm install command

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* adds helper function to wait for all pods in the namespace to be running

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* fixes username as base64 input

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* fix helper for deleting arango deployment

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* updates changelog

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* updates changelog

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* resolves ci checks and comments

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* adds function comment

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* removes unnecessary leading newline

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* adds feature for executing any query that returns a float value

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

* resolves pr comments

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an ArangoDB scaler
2 participants