Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple Grafana dashboard #3902

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

darox
Copy link
Contributor

@darox darox commented Nov 22, 2022

This commit adds a simple Grafana dashboard for the metrics exposed by Keda metric server.

Relates to #3911
Relates to kedacore/keda-docs#985

@darox darox requested a review from a team as a code owner November 22, 2022 13:02
@tomkerkhove
Copy link
Member

I like this idea, thank you! Do you have a screenshot of what it looks like?

Also, we should document this on https://keda.sh/docs/2.8/operate/ and add a section on Grafana which mentions this template and what it includes.

@darox
Copy link
Contributor Author

darox commented Nov 22, 2022

I like this idea, thank you! Do you have a screenshot of what it looks like?

Also, we should document this on https://keda.sh/docs/2.8/operate/ and add a section on Grafana which mentions this template and what it includes.

Sure
image

I'm open to improvements/wishes.

@darox
Copy link
Contributor Author

darox commented Nov 23, 2022

This is an even better representation of the operations performed by Keda:
image

It will visualize the changes by using the following metric:
changes(kube_deployment_spec_replicas{deployment=~"$scaledObject"}[1m])

I have updated the PR.

@darox darox force-pushed the add-grafana-dashbaord branch 2 times, most recently from c4c4dae to bc42df3 Compare November 23, 2022 06:14
@tomkerkhove
Copy link
Member

I love it!

Also, we should document this on keda.sh/docs/2.8/operate and add a section on Grafana which mentions this template and what it includes.

Any thoughts on this?

@darox
Copy link
Contributor Author

darox commented Nov 23, 2022

I love it!

Also, we should document this on keda.sh/docs/2.8/operate and add a section on Grafana which mentions this template and what it includes.

Any thoughts on this?

Sounds good. I will add docs. Give me some time.

I will put it here, ok?
image

@tomkerkhove
Copy link
Member

Sounds good!

This commit adds a simple Grafana dashboard for the metrics exposed by Keda metric server.

Signed-off-by: darox <9934402+darox@users.noreply.github.com>
@darox
Copy link
Contributor Author

darox commented Nov 23, 2022

Sounds good!

See kedacore/keda-docs#985

@tomkerkhove tomkerkhove merged commit ed779dd into kedacore:main Nov 24, 2022
@darox
Copy link
Contributor Author

darox commented Nov 24, 2022

Thank you for handling this PR so fast @tomkerkhove

@tomkerkhove
Copy link
Member

My pleasure, thank YOU!ç

@yuvalweber
Copy link
Contributor

what do you guys think about adding a panel that shows regarding how much replicas we have now against the max replicas. kube_horizontalpodautoscaler_status_current_replicas/ kube_horizontalpodautoscaler_spec_max_replicas ?

@tomkerkhove
Copy link
Member

Nice idea! Are you open to send a PR?

@yuvalweber
Copy link
Contributor

yuvalweber commented Nov 29, 2022

Added a PR please review @tomkerkhove #3934

josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants