-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support to use pod identities for authentication in Azure Key Vault #3814
Conversation
…ey Vault Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
/run-e2e keyvault* |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
/run-e2e keyvault* |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
/run-e2e keyvault* |
Besides the changes in 2.9 docs for adding this feature, we would require some changes in the earlier docs (I think 2.7, 2.8) to report this problem, right? |
I wouldn't change them, the feature it isn't documented in those version, so officially it doesn't exist xD |
I enabled pod identity / workload identity for key vault in #2907. But now that I look at it, the page for keyvault still mentions that pod identity is not supported. Funny. |
That's why I said that it isn't documented xD |
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
/run-e2e keyvault* |
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
...s/secret-providers/azure_keyvault_workload_identity/azure_keyvault_workload_identity_test.go
Outdated
Show resolved
Hide resolved
...s/secret-providers/azure_keyvault_workload_identity/azure_keyvault_workload_identity_test.go
Outdated
Show resolved
Hide resolved
...s/secret-providers/azure_keyvault_workload_identity/azure_keyvault_workload_identity_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
/run-e2e keyvault* |
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
This PR adds explicit support to use podIdentity only for Azure Key Vault and not for all scaler related things
Checklist
Fixes #3813