Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference ScaledObject's/ScaledJob's name in the scalers log #3485

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Reference ScaledObject's/ScaledJob's name in the scalers log #3485

merged 1 commit into from
Aug 3, 2022

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Aug 2, 2022 •
edited
Loading

Signed-off-by: Zbynek Roubalik zroubalik@gmail.com

Reference ScaledObject's/ScaledJob's name in the scalers log.

Sorry for the huge PR :(

Checklist

Relates #3419

@zroubalik zroubalik requested a review from a team as a code owner August 2, 2022 20:42
@JorTurFer
Copy link
Member

JorTurFer commented Aug 2, 2022 •
edited
Loading

Tomorrow morning I'll take a look with a large coffee xD

@zroubalik
Copy link
Member Author

Tomorrow morning I'll take a look with a large coffee xD

Thanks 😄

I don't understand what is the problem with the Static Checks and build, it complains about part of the code (kafkaLog variable) that is no longer present in the code 💩 It seems like some corrupted cache in the git? I tried to force push again, to rewrite the stuff, but no help.

@zroubalik
Copy link
Member Author

@JorTurFer for some reason GitHub wasn't able to process that huge PR. So I am going to split the change into multiple PRs. Once this first one is going to be merged, I will open the following PRs.

@zroubalik
Copy link
Member Author

zroubalik commented Aug 2, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member Author

zroubalik commented Aug 3, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Reference ScaledObject's/ScaledJob's name in the scalers log
6adfef1 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik merged commit fa7ffcc into kedacore:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zroubalik @JorTurFer