feat: introduce activationThreshold for New Relic Scaler #3427

pragmaticivan · 2022-07-26T21:46:16Z

Note that the service resource has a random suffix to narrow down the New Relic query so multiple e2e tests can run in parallel. It was helpful for local development but should also be for multiple PRs at the same time.

Checklist

Commits are signed with Developer Certificate of Origin (DCO - learn more)
Tests have been added
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Changelog has been updated and is aligned with our changelog requirements

Fixes #3244

Relates to #
Doc Change: kedacore/keda-docs#874

pragmaticivan · 2022-07-27T01:27:09Z

❯ go test -v -tags e2e ./scalers_go/new_relic/new_relic_test.go
=== RUN   TestNewRelicScaler
    new_relic_test.go:186: --- setting up ---
    helper.go:193: deleting namespace new-relic-test-ns
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:180: Creating namespace - new-relic-test-ns
    helper.go:361: Applying template: scaledObjectTemplate
    helper.go:361: Applying template: secretTemplate
    helper.go:361: Applying template: triggerAuthenticationTemplate
    helper.go:361: Applying template: serviceTemplate
    helper.go:361: Applying template: deploymentTemplate
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 1
    new_relic_test.go:212: --- testing activation ---
    helper.go:361: Applying template: lightLoadTemplate
    helper.go:319: Waiting for some time to ensure deployment replica count doesn't change
    new_relic_test.go:219: --- testing scale up ---
    helper.go:361: Applying template: heavyLoadTemplate
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 3
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 3
    new_relic_test.go:227: --- testing scale down ---
    helper.go:388: Deleting template: lightLoadTemplate
    helper.go:388: Deleting template: heavyLoadTemplate
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 3, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 2, Target - 1
    helper.go:261: Waiting for deployment replicas to hit target. Deployment - new-relic-test-deployment, Current  - 1, Target - 1
    helper.go:388: Deleting template: scaledObjectTemplate
    helper.go:388: Deleting template: secretTemplate
    helper.go:388: Deleting template: triggerAuthenticationTemplate
    helper.go:388: Deleting template: serviceTemplate
    helper.go:388: Deleting template: deploymentTemplate
    helper.go:193: deleting namespace new-relic-test-ns
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
    helper.go:206: waiting for namespace new-relic-test-ns deletion
--- PASS: TestNewRelicScaler (300.67s)
PASS
ok  	command-line-arguments	300.996s

tests/scalers_go/new_relic/new_relic_test.go

JorTurFer · 2022-07-30T19:05:27Z

/run-e2e relic
Update: You can check the progress here

JorTurFer · 2022-08-03T10:06:17Z

Tests are failing because NEWRELIC_REGION is not provided. This variable is optional and has default value 'EU', could you modify the test to maintain this behavior? Typescript test sets the default value if other isn't provided.
Could you rebase your branch too to avoid the conflicts?

JorTurFer · 2022-08-03T10:23:14Z

There are also static linter errors to address https://github.com/kedacore/keda/runs/7531987872?check_suite_focus=true
🙏

zroubalik · 2022-08-04T13:54:57Z

@pragmaticivan any update on this please? We would like to complete this by the end of the week. So we can ship a new release the next one.

Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>

JorTurFer · 2022-08-04T17:31:57Z

/run-e2e relic
Update: You can check the progress here

Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>

JorTurFer · 2022-08-04T18:20:16Z

/run-e2e relic*
Update: You can check the progress here

tests/scalers_go/new_relic/new_relic_test.go

Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>

v-shenoy · 2022-08-04T20:58:32Z

/run-e2e relic
Update: You can check the progress here

pragmaticivan · 2022-08-04T21:25:15Z

It looks like it's passing now.

JorTurFer

LGTM!
Thanks for this contribution! ❤️

pragmaticivan changed the title ~~test: migrate new relic tests to go~~ WIP - test: migrate new relic tests to go Jul 26, 2022

pragmaticivan force-pushed the feature/migrate-new-relic-tests branch 2 times, most recently from e1d3d27 to 87d2e7b Compare July 27, 2022 01:25

pragmaticivan changed the title ~~WIP - test: migrate new relic tests to go~~ test: migrate new relic tests to go Jul 27, 2022

pragmaticivan marked this pull request as ready for review July 27, 2022 01:29

pragmaticivan requested a review from a team as a code owner July 27, 2022 01:29

pragmaticivan changed the title ~~test: migrate new relic tests to go~~ test(#3244): migrate new relic tests to go Jul 27, 2022

zroubalik reviewed Jul 27, 2022

View reviewed changes

tests/scalers_go/new_relic/new_relic_test.go Outdated Show resolved Hide resolved

tests/scalers_go/new_relic/new_relic_test.go Show resolved Hide resolved

pragmaticivan force-pushed the feature/migrate-new-relic-tests branch from 189541e to b037868 Compare August 4, 2022 17:23

test: migrate new relic tests to go

fb9d70b

Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>

pragmaticivan force-pushed the feature/migrate-new-relic-tests branch from b037868 to fb9d70b Compare August 4, 2022 17:24

feat(kedacore#3244): add support for new relic activationThreshold

6014dc8

Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>

pragmaticivan mentioned this pull request Aug 4, 2022

feat: introduce activationThreshold for New Relic Scaler kedacore/keda-docs#874

Merged

1 task

JorTurFer reviewed Aug 4, 2022

View reviewed changes

tests/scalers_go/new_relic/new_relic_test.go Outdated Show resolved Hide resolved

test: fix service namespace indentation

668187d

Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>

JorTurFer mentioned this pull request Aug 4, 2022

Introduce activationThreshold/minMetricValue for all scalers #2800

Closed

7 tasks

JorTurFer approved these changes Aug 4, 2022

View reviewed changes

JorTurFer changed the title ~~test(#3244): migrate new relic tests to go~~ feat: introduce activationThreshold for New Relic Scaler Aug 4, 2022

JorTurFer enabled auto-merge (squash) August 4, 2022 22:32

JorTurFer merged commit 07517d8 into kedacore:main Aug 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: introduce activationThreshold for New Relic Scaler #3427

feat: introduce activationThreshold for New Relic Scaler #3427

pragmaticivan commented Jul 26, 2022 •

edited by JorTurFer

Loading

pragmaticivan commented Jul 27, 2022

JorTurFer commented Jul 30, 2022 •

edited by github-actions bot

Loading

JorTurFer commented Aug 3, 2022 •

edited

Loading

JorTurFer commented Aug 3, 2022

zroubalik commented Aug 4, 2022

JorTurFer commented Aug 4, 2022 •

edited by github-actions bot

Loading

JorTurFer commented Aug 4, 2022 •

edited by github-actions bot

Loading

v-shenoy commented Aug 4, 2022 •

edited by github-actions bot

Loading

pragmaticivan commented Aug 4, 2022

JorTurFer left a comment

feat: introduce activationThreshold for New Relic Scaler #3427

feat: introduce activationThreshold for New Relic Scaler #3427

Conversation

pragmaticivan commented Jul 26, 2022 • edited by JorTurFer Loading

Checklist

pragmaticivan commented Jul 27, 2022

JorTurFer commented Jul 30, 2022 • edited by github-actions bot Loading

JorTurFer commented Aug 3, 2022 • edited Loading

JorTurFer commented Aug 3, 2022

zroubalik commented Aug 4, 2022

JorTurFer commented Aug 4, 2022 • edited by github-actions bot Loading

JorTurFer commented Aug 4, 2022 • edited by github-actions bot Loading

v-shenoy commented Aug 4, 2022 • edited by github-actions bot Loading

pragmaticivan commented Aug 4, 2022

JorTurFer left a comment

Choose a reason for hiding this comment

pragmaticivan commented Jul 26, 2022 •

edited by JorTurFer

Loading

JorTurFer commented Jul 30, 2022 •

edited by github-actions bot

Loading

JorTurFer commented Aug 3, 2022 •

edited

Loading

JorTurFer commented Aug 4, 2022 •

edited by github-actions bot

Loading

JorTurFer commented Aug 4, 2022 •

edited by github-actions bot

Loading

v-shenoy commented Aug 4, 2022 •

edited by github-actions bot

Loading