Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce activationThreshold/minMetricValue for MongoDB Scaler #3405

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jul 19, 2022

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)

Related to #2800
Related to kedacore/keda-docs#826
Related to #3380

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner July 19, 2022 19:42
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 19, 2022

/run-e2e mongo*
Update: You can check the progress here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the test has failed.

@JorTurFer
Copy link
Member Author

LGTM, though the test has failed.

just in case, let me fix the maxReplicas in the e2e test to avoid this behavior in the future and avoid flaky tests

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jul 20, 2022

/run-e2e mongo*
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 70c45a4 into kedacore:main Jul 20, 2022
@JorTurFer JorTurFer deleted the activation-threshold-mongo branch July 20, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants