-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Trigger Authentication for InfluxDB #1904
Add support for Trigger Authentication for InfluxDB #1904
Conversation
…rverURL from (Cluster)TriggerAuthentication Signed-off-by: Andy Cobaugh <andrew.cobaugh@gmail.com>
5dc342d
to
9128a2d
Compare
I believe the docs can be left as-is since I think this PR just brings the code in line with the documented behavior. Otherwise I can go ahead and get a PR worked up for that as well. |
I don't want to be a pain, but it should only be used for authentication information, unless the auth token is specific to the server URL + org combination of course. WDYT @zroubalik ? Based on the outcome here, we'd need a PR on our docs as well |
I am fine with including url and organization name, but it's up to you @tomkerkhove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we'll need a PR on https://github.com/kedacore/keda-docs.
Would be nice if you could fix the docs in previous versions to remove TA support since it's not the case
Signed-off-by: misha <mishamo@gmail.com>
Signed-off-by: misha <mishamo@gmail.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
This allows
authToken
,serverURL
, andorganizationName
to be sourced fromTriggerAuthentication
andClusterTriggerAuthentication
by the influxdb scaler.Relates to #1905
Relates to #1892
Checklist