Ensure that all scalers are closed #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Boutet <mboutet@explorance.com>
Signed-off-by: Maxence Boutet <mboutet@explorance.com>
ycabrer
pushed a commit
to ycabrer/keda
that referenced
this pull request
Mar 1, 2021
* Ensure that all scalers are closed before breaking out the loop Signed-off-by: Maxence Boutet <mboutet@explorance.com> * Update changelog Signed-off-by: Maxence Boutet <mboutet@explorance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maxence Boutet mboutet@explorance.com
In
checkScaledObjectScalers, as soon as one active scaler is encountered, all the remaining scalers are not closed leading to ever increasing memory usage. This PR ensures that all the remaining scalers are closed after one active scaler has been found.Checklist
Fixes #1413