-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Azure Key Vault support in TriggerAuthentication #900
Comments
+1 on this. |
How would the general approach be? I am a bit confused on how I would need to start on it if I wanted to contribute. |
We provide a contribution guide on https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md but I'd ask @zroubalik @ahmelsayed @JorTurFer for more in-depth guidance. We should, however, document how to add a new authentication source. |
This should directly talk to Azure Key Vault as Azure Key Vault Provider for Secrets Store CSI Driver is another scenario to cover that should already work today. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
still want this feature and I think it should come! |
We are happy to review PRs ;) |
I know. just wanted to keep this open for now 😜 |
I plan on taking this up. @tomkerkhove |
Thank you! |
Got a bit busy with some other work, working on this. Commenting so that the issue doesn't get marked as stale. |
No worries, issue won't get stale and take your time - Thanks for the update! |
Could you provide me some more resources I could read up on for adding authentication sources? @tomkerkhove |
We don't have any docs on adding auth providers I think, but we should add this. Or am I mistaken @JorTurFer @zroubalik ? |
Nope, it's in the code though 😅 |
Provide Azure Key Vault support in TriggerAuthentication to pull secrets from.
The text was updated successfully, but these errors were encountered: