Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden GitHub Runner Spec #4651

Closed
Eldarrin opened this issue Jun 6, 2023 · 11 comments · Fixed by #4708
Closed

Harden GitHub Runner Spec #4651

Eldarrin opened this issue Jun 6, 2023 · 11 comments · Fixed by #4708
Assignees
@Eldarrin
Labels
feature All issues for new features that have been committed to help wanted Looking for support from community

Comments

@Eldarrin
Copy link
Contributor

Eldarrin commented Jun 6, 2023

Proposal

Use a GitHub App to provide a more secure access to GitHub for the runners as opposed to a PAT token and gain increased api usage. (15k vs 5k / hour)

Use-Case

More secure runner integration with github using certs as opposed to keys

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response
@Eldarrin Eldarrin added feature-request All issues for new features that have not been committed to needs-discussion labels Jun 6, 2023
@JorTurFer
Copy link
Member

JorTurFer commented Jun 6, 2023 •
edited by tomkerkhove
Loading

This would be an awesome improvement ❤️
We will cut a release in 2 weeks or so, do you think that you will have time? (no rush at all)

@tomkerkhove tomkerkhove added help wanted Looking for support from community feature All issues for new features that have been committed to and removed feature-request All issues for new features that have not been committed to needs-discussion labels Jun 8, 2023
@Eldarrin
Copy link
Contributor Author

This would be an awesome improvement ❤️ We will cut a release in 2 weeks or so, do you think that you will have time? (no rush at all)

No promises, need to fix my video driver on my RHEL box first, lol

@piroinno
Copy link

I was just thinking about this a few days ago. Looking forward to this!

@zroubalik
Copy link
Member

video driver on my RHEL box

Well, this is a combination that one doesn't see every day 😄

This was referenced Jun 19, 2023
Merged
Merged
Merged
@Eldarrin
Copy link
Contributor Author

@JorTurFer Docs, test tool mods and code PR opened. Test tools and app bit needs to be done before running the e2e.

@piroinno
Copy link

This would be an awesome improvement ❤️ We will cut a release in 2 weeks or so, do you think that you will have time? (no rush at all)

No promises, need to fix my video driver on my RHEL box first, lol

Hows that fix going :-)

@JorTurFer
Copy link
Member

@Eldarrin , I'll prepare everything later on :)

@JorTurFer
Copy link
Member

I have done all the steps, let's see if I have done them well 🤞

@piroinno
Copy link

Looks good. Need an approver?

@JorTurFer
Copy link
Member

We are reviewing it @piroinno

@piroinno
Copy link

Thanks all!

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
@Eldarrin @JorTurFer
@zroubalik @tomkerkhove
Docs for new GitHub App on GH Runner (kedacore#4651) (kedacore#1159)
e2aa2be 
Signed-off-by: Andy Ward <mortx@toothless.eldarrin.io>
Signed-off-by: Eldarrin <mortxbox@live.com>
Signed-off-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eldarrin Eldarrin

Labels
feature All issues for new features that have been committed to help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce GitHub App authentication for GitHub Scaler
5 participants
@zroubalik @tomkerkhove @piroinno @Eldarrin @JorTurFer