-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Emit kubernetes events from KEDA (#1523)
* Emit kubernetes events from KEDA Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com> * CR comments Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com> * Fix CI errors Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com> * goimports Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com> * Code review comments Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com> * Fix CHANGELOG.md Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com>
- Loading branch information
1 parent
df9ee68
commit aac70e6
Showing
15 changed files
with
218 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
package controllers | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/go-logr/logr" | ||
kedav1alpha1 "github.com/kedacore/keda/v2/api/v1alpha1" | ||
"github.com/kedacore/keda/v2/pkg/eventreason" | ||
corev1 "k8s.io/api/core/v1" | ||
"k8s.io/apimachinery/pkg/api/errors" | ||
"k8s.io/client-go/tools/record" | ||
ctrl "sigs.k8s.io/controller-runtime" | ||
"sigs.k8s.io/controller-runtime/pkg/builder" | ||
"sigs.k8s.io/controller-runtime/pkg/client" | ||
"sigs.k8s.io/controller-runtime/pkg/predicate" | ||
) | ||
|
||
// +kubebuilder:rbac:groups=keda.sh,resources=triggerauthentications;triggerauthentications/status,verbs="*" | ||
|
||
// TriggerAuthenticationReconciler reconciles a TriggerAuthentication object | ||
type TriggerAuthenticationReconciler struct { | ||
Client client.Client | ||
Log logr.Logger | ||
Recorder record.EventRecorder | ||
} | ||
|
||
// Reconcile performs reconciliation on the identified TriggerAuthentication resource based on the request information passed, returns the result and an error (if any). | ||
func (r *TriggerAuthenticationReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) { | ||
reqLogger := r.Log.WithValues("TriggerAuthentication.Namespace", req.Namespace, "TriggerAuthentication.Name", req.Name) | ||
|
||
triggerAuthentication := &kedav1alpha1.TriggerAuthentication{} | ||
err := r.Client.Get(context.TODO(), req.NamespacedName, triggerAuthentication) | ||
if err != nil { | ||
if errors.IsNotFound(err) { | ||
return ctrl.Result{}, nil | ||
} | ||
reqLogger.Error(err, "Failed ot get TriggerAuthentication") | ||
return ctrl.Result{}, err | ||
} | ||
|
||
if triggerAuthentication.GetDeletionTimestamp() != nil { | ||
r.Recorder.Event(triggerAuthentication, corev1.EventTypeNormal, eventreason.TriggerAuthenticationDeleted, "TriggerAuthentication was deleted") | ||
return ctrl.Result{}, nil | ||
} | ||
|
||
if triggerAuthentication.ObjectMeta.Generation == 1 { | ||
r.Recorder.Event(triggerAuthentication, corev1.EventTypeNormal, eventreason.TriggerAuthenticationAdded, "New TriggerAuthentication configured") | ||
} | ||
|
||
return ctrl.Result{}, nil | ||
} | ||
|
||
// SetupWithManager initializes the TriggerAuthenticationReconciler instance and starts a new controller managed by the passed Manager instance. | ||
func (r *TriggerAuthenticationReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||
return ctrl.NewControllerManagedBy(mgr). | ||
For(&kedav1alpha1.TriggerAuthentication{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})). | ||
Complete(r) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* | ||
Copyright 2020 The KEDA Authors | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package eventreason | ||
|
||
const ( | ||
// ScaledObjectReady is for event when a new ScaledObject is ready | ||
ScaledObjectReady = "ScaledObjectReady" | ||
|
||
// ScaledJobReady is for event when a new ScaledJob is ready | ||
ScaledJobReady = "ScaledJobReady" | ||
|
||
// ScaledObjectCheckFailed is for event when ScaledObject validation check fails | ||
ScaledObjectCheckFailed = "ScaledObjectCheckFailed" | ||
|
||
// ScaledJobCheckFailed is for event when ScaledJob validation check fails | ||
ScaledJobCheckFailed = "ScaledJobCheckFailed" | ||
|
||
// ScaledObjectDeleted is for event when ScaledObject is deleted | ||
ScaledObjectDeleted = "ScaledObjectDeleted" | ||
|
||
// ScaledJobDeleted is for event when ScaledJob is deleted | ||
ScaledJobDeleted = "ScaledJobDeleted" | ||
|
||
// KEDAScalersStarted is for event when scalers watch started for ScaledObject or ScaledJob | ||
KEDAScalersStarted = "KEDAScalersStarted" | ||
|
||
// KEDAScalersStopped is for event when scalers watch was stopped for ScaledObject or ScaledJob | ||
KEDAScalersStopped = "KEDAScalersStopped" | ||
|
||
// KEDAScalerFailed is for event when a scaler fails for a ScaledJob or a ScaledObject | ||
KEDAScalerFailed = "KEDAScalerFailed" | ||
|
||
// KEDAScaleTargetActivated is for event when the scale target of ScaledObject was activated | ||
KEDAScaleTargetActivated = "KEDAScaleTargetActivated" | ||
|
||
// KEDAScaleTargetDeactivated is for event when the scale target for ScaledObject was deactivated | ||
KEDAScaleTargetDeactivated = "KEDAScaleTargetDeactivated" | ||
|
||
// KEDAScaleTargetActivationFailed is for event when the activation the scale target for ScaledObject fails | ||
KEDAScaleTargetActivationFailed = "KEDAScaleTargetActivationFailed" | ||
|
||
// KEDAScaleTargetDeactivationFailed is for event when the deactivation of the scale target for ScaledObject fails | ||
KEDAScaleTargetDeactivationFailed = "KEDAScaleTargetDeactivationFailed" | ||
|
||
// KEDAJobsCreated is for event when jobs for ScaledJob are created | ||
KEDAJobsCreated = "KEDAJobsCreated" | ||
|
||
// TriggerAuthenticationDeleted is for event when a TriggerAuthentication is deleted | ||
TriggerAuthenticationDeleted = "TriggerAuthenticationDeleted" | ||
|
||
// TriggerAuthenticationAdded is for event when a TriggerAuthentication is added | ||
TriggerAuthenticationAdded = "TriggerAuthenticationAdded" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.