Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Restrict Secret Access" part #955

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

kevinteng525
Copy link
Contributor

Add "Restrict Secret Access" part

Refer to Issue: kedacore/keda#3668
PR: kedacore/keda#3677

@kevinteng525 kevinteng525 requested a review from a team as a code owner October 9, 2022 14:13
@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 6c341f8
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6391df51c7c0260008cfd6ce
😎 Deploy Preview https://deploy-preview-955--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did some suggestions

content/docs/2.8/operate/cluster.md Outdated Show resolved Hide resolved
content/docs/2.9/operate/cluster.md Outdated Show resolved Hide resolved
content/docs/2.9/operate/cluster.md Outdated Show resolved Hide resolved
content/docs/2.9/operate/cluster.md Outdated Show resolved Hide resolved
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but waiting for feature to be merged

Add "Restrict Secret Access" part

Signed-off-by: kevin <tengkang@msn.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer PTAL

@zroubalik zroubalik merged commit 0dccb25 into kedacore:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants