Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expand readOnlyRootFilesystem answer #830

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix: expand readOnlyRootFilesystem answer #830

merged 1 commit into from
Jul 21, 2022

Conversation

joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Jul 21, 2022 •
edited
Loading

Expands FAQ answer regarding running keda-metrics-apiserver with readOnlyRootFilesystem=true

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to:

@joebowbeer
fix: expand readOnlyRootFilesystem answer
0d5cc78 
Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
@netlify
Copy link

netlify bot commented Jul 21, 2022 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 0d5cc78
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/62d8ef719476ba0009883b68
😎 Deploy Preview https://deploy-preview-830--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joebowbeer joebowbeer mentioned this pull request Jul 21, 2022
Closed
tomkerkhove
tomkerkhove approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton, very good addition!

@tomkerkhove tomkerkhove merged commit f5411cc into kedacore:main Jul 21, 2022
@joebowbeer joebowbeer deleted the patch-1 branch July 21, 2022 17:18
@joebowbeer joebowbeer mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@zroubalik zroubalik Awaiting requested review from zroubalik

@JorTurFer JorTurFer Awaiting requested review from JorTurFer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joebowbeer @tomkerkhove