Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation changes for Azure Key Vault support. #704

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

v-shenoy
Copy link
Contributor

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Documentation changes for Azure Key Vault support.
kedacore/keda#2727

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@netlify
Copy link

netlify bot commented Mar 10, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 78e4a69

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/6231b1bbc39a800008226389

😎 Browse the preview: https://deploy-preview-704--keda.netlify.app/docs/2.7/concepts/authentication

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs, thank you!

Added a suggestion to reshuffle things a bit

content/docs/2.7/concepts/authentication.md Outdated Show resolved Hide resolved
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Waiting with merging until feature is in

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a typo

content/docs/2.7/concepts/authentication.md Outdated Show resolved Hide resolved
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@zroubalik zroubalik merged commit 910d1a5 into kedacore:main Mar 16, 2022
@v-shenoy v-shenoy deleted the azure-key-vault-support branch March 16, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants