Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for custom KEDA scaler for Splunk Observability Cloud #1477

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sschimper-splunk
Copy link

With this pull request, I would like to submit documentation on a custom KEDA scaler for Splunk Observability Cloud, which I have developed and which at the moment of this submission resides here. Once I create my pull request for the scaler itself, I will reference this PR for the docs.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>
@sschimper-splunk sschimper-splunk requested a review from a team as a code owner September 26, 2024 08:01
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for keda failed.

Name Link
🔨 Latest commit 9c0502d
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66f6486c9a90ad0008996abb

@@ -0,0 +1,131 @@
+++
title = "Splunk Observability"
availability = "v2.15+"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be 2.16+ assuming the new scaler is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sschimper-splunk looks like you put 2.6 instead of 2.16 by mistake

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the version isn't available yet, the build will fail. So you need to explicitly ignore the URL like this: https://github.com/kedacore/keda-docs/pull/1413/files#diff-9ad64044531d7d8c033064f11141586478b535147312374c24f8d2d997722889R7

metadata:
name: splunk-secrets
data:
accessToken: dGVzdF9hY2Nlc3NfdG9rZW4= # base64-encrypted example access token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base64 encoded since base64 isn't encryption

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants