Admission Webhooks won't be mandatory #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JorTurFer
approved these changes
May 30, 2023
|
@JorTurFer @zroubalik Care to share why we suddenly changed our mind? Making it an opt-out is different from making it mandatory IMO since it is configurable. I presume you mean in terms of the YAML that we provide? |
|
I think that we discussed it by slack (but I could be wrong or maybe we did it in other channel) all together, but the summary is that there are cases where users are not allowed to deploy cluster scoped resources (at least in my mind) As default the feature will be activated, but the option in the chart will be maintained |
|
Yeah, let's keep it a default option, but keep an option to disable for a specific cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Relates: kedacore/charts#453