http-add-on: migrate v1.Endpoints to discoveryv1.EndpointSlices #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the KEDA HTTP add-on from using deprecated v1.Endpoints to the newer discoveryv1.EndpointSlices API, aligning with Kubernetes best practices and preparing for future compatibility.
- Updates RBAC permissions to use
discovery.k8s.ioAPI group instead of core API - Changes resource permissions from
endpointstoendpointslices - Bumps application version from 0.10.0 to 0.11.0
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| http-add-on/templates/scaler/rbac.yml | Updates RBAC permissions for scaler component to use EndpointSlices |
| http-add-on/templates/interceptor/rbac.yml | Updates RBAC permissions for interceptor component to use EndpointSlices |
| http-add-on/Chart.yaml | Bumps appVersion to reflect the API migration changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zroubalik
reviewed
Sep 18, 2025
wozniakjan
force-pushed
the
http-add-on_migrate_endpoints_to_endpointslices
branch
from
384e6eb to
062b7f3
Compare
JorTurFer
approved these changes
Sep 22, 2025
robinderooij-rl
pushed a commit
to RosemanLabs/keda-charts
that referenced
this pull request
Sep 30, 2025
…core#779) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Robin de Rooij <robin.de.rooij@rosemanlabs.com>
wozniakjan
added a commit
that referenced
this pull request
Oct 6, 2025
* Add ability to add extra ENV vars to containers The http-add-on chart did not have the ability yet to add custom extra env variables to the deployments. This implements it according to the standard set in the PR implementing the extra container ags, using an object instead of a list of objects. (See for this PR: #245) A previous PR was already made some time ago but it did not adhere to the requested convention: #762 This PR tries to solve that issue. Signed-off-by: Robin de Rooij <robin.de.rooij@rosemanlabs.com> * Allow Keda to request SA tokens (#728) * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <bnzelic@gmail.com> * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <bnzelic@gmail.com> * Allow Keda to request SA tokens Signed-off-by: Bojan Zelic <bnzelic@gmail.com> --------- Signed-off-by: Bojan Zelic <bnzelic@gmail.com> Signed-off-by: Robin de Rooij <robin.de.rooij@rosemanlabs.com> * Move global extraEnvs object to their components Signed-off-by: Robin de Rooij <robin.de.rooij@rosemanlabs.com> * http-add-on: migrate v1.Endpoints to discoveryv1.EndpointSlices (#779) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Robin de Rooij <robin.de.rooij@rosemanlabs.com> * release http-add-on v0.11.0 (#780) Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Robin de Rooij <robin.de.rooij@rosemanlabs.com> * Add to README Signed-off-by: Robin de Rooij <robin.de.rooij@rosemanlabs.com> --------- Signed-off-by: Robin de Rooij <robin.de.rooij@rosemanlabs.com> Signed-off-by: Bojan Zelic <bnzelic@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Bojan Zelic <bnzelic@gmail.com> Co-authored-by: Jan Wozniak <jan@kedify.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also: kedacore/http-add-on#1298
see also: kedacore/http-add-on#1297
Checklist