Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct default registry value in values.yaml #660

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Correct default registry value in values.yaml #660

merged 1 commit into from
Jul 10, 2024

Conversation

semihbkgr
Copy link
Contributor

@semihbkgr semihbkgr commented Jul 5, 2024 •
edited
Loading

It updates the values.yaml file to correctly separate the registry and repository values for the KEDA image.

Changes Made:

  • Set the default value of image.keda.registry to ghcr.io.
  • Adjusted image.keda.repository to kedacore/keda.

Checklist

@semihbkgr semihbkgr requested a review from a team as a code owner July 5, 2024 15:01
@semihbkgr
correct default registry value
f8ab76e 
Signed-off-by: semihbkgr <buyukgungorsemih@gmail.com>
zroubalik
zroubalik approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomkerkhove tomkerkhove merged commit 8b3a8ec into kedacore:main Jul 10, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@semihbkgr @zroubalik @tomkerkhove