feat(keda): Allow using own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerodayyy
changed the title
zroubalik
reviewed
Sep 27, 2023
JorTurFer
reviewed
Sep 27, 2023
|
@JorTurFer @zroubalik thanks for the review! I've updated the PR to address the comments |
JorTurFer
reviewed
Oct 3, 2023
|
Could you take a look to DCO check too? It's failing: https://github.com/kedacore/charts/pull/530/checks?check_run_id=17317958846 |
|
DCO is still failing. You can check the process to fix it clicking here:
|
|
Any progress on these last steps failures? |
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
…wn Issuer Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Loïs Postula <lois@postu.la> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
…#506) Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: yuval weber <yuval199985@gmail.com> Signed-off-by: unknown <yuval199985@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
#553) Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
#572) * Add CloudEventSources Crd and ClustetName Parameter Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update keda/values.yaml Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Fix Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Revert unnecessary update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> --------- Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
* chore: Adjust RBAC with code Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix typo Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Frank Kloeker <f.kloeker@telekom.de> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Align deployment for extraVolumes and extraVolumesMount for fix problem Error: YAML parse error on keda/templates/webhooks/deployment.yaml: error converting YAML to JSON: yaml: line 96: did not find expected key Signed-off-by: ferndem <39851927+ferndem@users.noreply.github.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
The current state of the Helm chart is slightly confusing, because: - There's no easy way to really disable prometheus metrics -- `--enable-prometheus-metrics` defaults to true anthe current code either emits `--enable-prometheus-metrics=true` or nothing at all (making it `true` once again). - The `http` container port is actually a `metrics` port (by convention from .e.g. webhook), but is present regardless of whether Prometheus metrics are enabled or not. To make it less confusing, this PR proposes renaming it. Signed-off-by: Milan Plzik <milan.plzik@grafana.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: choisungwook <kgg1959@naver.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
* support crd-specific annotations Signed-off-by: Adam Walford <adamw@speechmatics.com> * update readme Signed-off-by: Adam Walford <adamw@speechmatics.com> * update docs using helm-docs Signed-off-by: Adam Walford <adamw@speechmatics.com> --------- Signed-off-by: Adam Walford <adamw@speechmatics.com> Co-authored-by: Adam Walford <adamw@speechmatics.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Co-authored-by: guicholeo <leo.sanchez@resideo.com> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
Signed-off-by: Dmytro Kovalenko <zerodayyy@zerodayyy.xyz>
|
Hey @zroubalik @JorTurFer I've addressed the comments and DCO check, could you please take a look? Thanks a lot |
JorTurFer
approved these changes
Jan 30, 2024
|
Thanks! Just wondering, when are you planning to release a new chart version that would include this change? |
|
We don't have any expected date yet |
|
I gues that we could cut a helm release. WDYT @kedacore/keda-helm-contributors ? |
|
That would be great! |
4 tasks
|
Hey @JorTurFer @kedacore/keda-helm-contributors any leads when it would be possible to have this feature released (maybe as a patch version of the chart)? It would help a lot if it would be possible to release before KEDA itself has a new version. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to provide reference to their own Cert-manager Issuer/ClusterIssuer for issuing KEDA TLS certificates.
Checklist