Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics-apiserver misconfigured args/command #693

Open
or-shachar opened this issue Oct 21, 2024 · 0 comments · May be fixed by #694
Open

metrics-apiserver misconfigured args/command #693

or-shachar opened this issue Oct 21, 2024 · 0 comments · May be fixed by #694
Labels
bug Something isn't working

Comments

@or-shachar
Copy link

  • Looking at dockerfile of metrics-apiserver the binary is copied over to / and the entrypoint is: ENTRYPOINT ["/keda-adapter", "--secure-port=6443", "--logtostderr=true", "--v=0"], which is the same pattern of keda and webhooks images.
  • The chart deployment object has different pattern for metrics-apiserver for some reason. It doesn't define command and it reference the binary at /usr/local/bin:

This for some reason doesn't fail when using the regular distroless image but when I tried to use custom build - it started to fail.

Expected Behavior

The metrics server should have command: ["/keda-adapter"] just like other Deployment objects

Actual Behavior

The metrics server doesn't have command at all and defines wrong path to the binary in args.

Specifications

  • KEDA Version: 2.15.0
  • Platform & Version: Irrelevant
  • Kubernetes Version: Irrelevant
  • Scaler(s): Irrelevant
@or-shachar or-shachar added the bug Something isn't working label Oct 21, 2024
or-shachar added a commit to or-shachar/charts that referenced this issue Oct 21, 2024
Fixes kedacore#693 

Signed-off-by: Or Shachar <orchoock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant